[tor-commits] [stem/master] Slightly tweak new swo check

atagar at torproject.org atagar at torproject.org
Thu Nov 3 16:57:01 UTC 2016


commit 6a1764524990506bf09d2ec5ddea0b160e231077
Author: Damian Johnson <atagar at torproject.org>
Date:   Thu Nov 3 09:53:51 2016 -0700

    Slightly tweak new swo check
    
    Minorest of minor nitpicks. Was perfectly fine, just prefer a blank line and
    for exclude to be in the conditional (imho didn't previously add any
    readability).
---
 test/integ/installation.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/integ/installation.py b/test/integ/installation.py
index 533aefd..50c0339 100644
--- a/test/integ/installation.py
+++ b/test/integ/installation.py
@@ -82,8 +82,8 @@ class TestInstallation(unittest.TestCase):
     for root, dirnames, filenames in os.walk(os.path.join(BASE_DIRECTORY, 'stem')):
       for filename in filenames:
           file_format = filename.split('.')[-1]
-          excluded = ['pyc', 'swp', 'swo']
-          if not file_format in excluded:
+
+          if file_format not in ('pyc', 'swp', 'swo'):
             expected.add(os.path.join(root, filename)[len(BASE_DIRECTORY) + 1:])
 
     for root, dirnames, filenames in os.walk(self.site_packages_path):





More information about the tor-commits mailing list