[tor-commits] [tor/master] Fix a bad sizeof() in test_crypto.c. Harmless. Spotted by coverity.

nickm at torproject.org nickm at torproject.org
Wed May 18 12:30:26 UTC 2016


commit 159ea7a88f31aee2f84cf964c0d0000a5bd98970
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed May 18 08:29:13 2016 -0400

    Fix a bad sizeof() in test_crypto.c. Harmless. Spotted by coverity.
---
 src/test/test_crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_crypto.c b/src/test/test_crypto.c
index 5205945..e6b250a 100644
--- a/src/test/test_crypto.c
+++ b/src/test/test_crypto.c
@@ -126,7 +126,7 @@ test_crypto_dh(void *arg)
     s1len = crypto_dh_compute_secret(LOG_WARN, dh1, p1, DH_BYTES, s1, 50);
     tt_int_op(-1, OP_EQ, s1len);
 
-    memset(p1, 0xff, sizeof(DH_BYTES)), /* 2^1024-1 */
+    memset(p1, 0xff, DH_BYTES), /* 2^1024-1 */
     s1len = crypto_dh_compute_secret(LOG_WARN, dh1, p1, DH_BYTES, s1, 50);
     tt_int_op(-1, OP_EQ, s1len);
   }



More information about the tor-commits mailing list