[tor-commits] [tor/master] dir auths only give Guard if they're giving Stable

[nickm at torproject.org]

commit c4208ef65f58836670dab286bad0289259582124
Author: Roger Dingledine <arma at torproject.org>
Date:   Thu Mar 24 15:00:01 2016 -0400

    dir auths only give Guard if they're giving Stable
    
    This change allows us to simplify path selection for clients, and it
    should have minimal effect in practice since >99% of Guards already have
    the Stable flag. Implements ticket 18624.
---
 changes/feature18624 | 7 +++++++
 src/or/dirserv.c     | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/changes/feature18624 b/changes/feature18624
new file mode 100644
index 0000000..a3be90f
--- /dev/null
+++ b/changes/feature18624
@@ -0,0 +1,7 @@
+  o Minor features:
+    - Directory authorities now only give the Guard flag to a relay if
+      they are also giving it the Stable flag. This change allows us to
+      simplify path selection for clients, and it should have minimal
+      effect in practice since >99% of Guards already have the Stable
+      flag. Implements ticket 18624.
+
diff --git a/src/or/dirserv.c b/src/or/dirserv.c
index a045f3a..f012b7b 100644
--- a/src/or/dirserv.c
+++ b/src/or/dirserv.c
@@ -2200,7 +2200,7 @@ set_routerstatus_from_routerinfo(routerstatus_t *rs,
 
   rs->is_valid = node->is_valid;
 
-  if (node->is_fast &&
+  if (node->is_fast && node->is_stable &&
       ((options->AuthDirGuardBWGuarantee &&
         routerbw_kb >= options->AuthDirGuardBWGuarantee/1000) ||
        routerbw_kb >= MIN(guard_bandwidth_including_exits_kb,