[tor-commits] [tor/master] remove extraneous breaks

arma at torproject.org arma at torproject.org
Mon Mar 21 21:13:52 UTC 2016


commit 580e549f75e43a1452f982949977f67691cc1a5a
Author: Roger Dingledine <arma at torproject.org>
Date:   Mon Mar 21 17:11:18 2016 -0400

    remove extraneous breaks
    
    commit edeba3d4 removed a switch, but left the "break" lines in
    from that switch. fortunately the resulting behavior was not wrong,
    since there was an outer switch that it was ok to break from.
---
 src/or/directory.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/or/directory.c b/src/or/directory.c
index 7130041..52cc6a9 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -2305,7 +2305,6 @@ connection_dir_client_reached_eof(dir_connection_t *conn)
            * cleans this dir conn up. */
           SEND_HS_DESC_FAILED_EVENT("BAD_DESC");
           SEND_HS_DESC_FAILED_CONTENT();
-          break;
         } else {
           char service_id[REND_SERVICE_ID_LEN_BASE32 + 1];
           /* Should never be NULL here if we found the descriptor. */
@@ -2325,7 +2324,6 @@ connection_dir_client_reached_eof(dir_connection_t *conn)
           conn->base_.purpose = DIR_PURPOSE_HAS_FETCHED_RENDDESC_V2;
           rend_client_desc_trynow(service_id);
           memwipe(service_id, 0, sizeof(service_id));
-          break;
         }
         break;
       }



More information about the tor-commits mailing list