[tor-commits] [tor/master] Correctly duplicate addresses in get_interface_address6_list

[nickm at torproject.org]

commit 9f98e6535ac58afa0cc56a4a5d9164fedead4b3c
Author: teor (Tim Wilson-Brown) <teor2345 at gmail.com>
Date:   Fri Mar 4 18:42:27 2016 +0100

    Correctly duplicate addresses in get_interface_address6_list
---
 src/common/address.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/common/address.c b/src/common/address.c
index c77b0f3..793a40e 100644
--- a/src/common/address.c
+++ b/src/common/address.c
@@ -1790,7 +1790,7 @@ MOCK_IMPL(smartlist_t *,get_interface_address6_list,(int severity,
     if (get_interface_address6_via_udp_socket_hack(severity,AF_INET,
                                                    &addr) == 0) {
       if (include_internal || !tor_addr_is_internal(&addr, 0)) {
-        smartlist_add(addrs, tor_dup_addr(&addr));
+        smartlist_add(addrs, tor_memdup(&addr, sizeof(addr)));
       }
     }
   }
@@ -1799,7 +1799,7 @@ MOCK_IMPL(smartlist_t *,get_interface_address6_list,(int severity,
     if (get_interface_address6_via_udp_socket_hack(severity,AF_INET6,
                                                    &addr) == 0) {
       if (include_internal || !tor_addr_is_internal(&addr, 0)) {
-        smartlist_add(addrs, tor_dup_addr(&addr));
+        smartlist_add(addrs, tor_memdup(&addr, sizeof(addr)));
       }
     }
   }