[tor-commits] [tor/master] Patch from dgoulet: fix a base16 problem that manifested w stem

[nickm at torproject.org]

commit 2f75b34dcede23dad8835a941539935e82cf7988
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Jun 20 13:37:45 2016 -0400

    Patch from dgoulet: fix a base16 problem that manifested w stem
---
 src/or/control.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/or/control.c b/src/or/control.c
index f956307..6e5dcf6 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -1264,7 +1264,7 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len,
     password_len = i/2;
     password = tor_malloc(password_len + 1);
     if (base16_decode(password, password_len+1, body, i)
-                      != (int) (password_len+1)) {
+                      != (int) password_len) {
       connection_write_str_to_buf(
             "551 Invalid hexadecimal encoding.  Maybe you tried a plain text "
             "password?  If so, the standard requires that you put it in "