[tor-commits] [metrics-lib/master] All clean according to checkstyle.

karsten at torproject.org karsten at torproject.org
Thu Jul 7 08:24:55 UTC 2016


commit ac5ff698c9585d4f5414e40cd6dd978692e8409a
Author: iwakeh <iwakeh at torproject.org>
Date:   Thu Jul 7 10:02:29 2016 +0200

    All clean according to checkstyle.
---
 .gitignore                                                           | 1 +
 .../java/org/torproject/descriptor/impl/BridgeNetworkStatusImpl.java | 2 ++
 .../java/org/torproject/descriptor/impl/DownloadCoordinatorImpl.java | 3 +++
 src/main/java/org/torproject/descriptor/impl/NetworkStatusImpl.java  | 5 +++++
 4 files changed, 11 insertions(+)

diff --git a/.gitignore b/.gitignore
index bb59c26..f2c33a8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
 classes/
+cobertura.ser
 generated/
 lib/
 descriptor-*.jar
diff --git a/src/main/java/org/torproject/descriptor/impl/BridgeNetworkStatusImpl.java b/src/main/java/org/torproject/descriptor/impl/BridgeNetworkStatusImpl.java
index 6a56d44..8e456db 100644
--- a/src/main/java/org/torproject/descriptor/impl/BridgeNetworkStatusImpl.java
+++ b/src/main/java/org/torproject/descriptor/impl/BridgeNetworkStatusImpl.java
@@ -144,6 +144,8 @@ public class BridgeNetworkStatusImpl extends NetworkStatusImpl
           case "ignoring-advertised-bws":
             this.ignoringAdvertisedBws = Integer.parseInt(e.getValue());
             break;
+          default:
+            /* nothing to be done */
         }
       }
     } catch (NumberFormatException ex) {
diff --git a/src/main/java/org/torproject/descriptor/impl/DownloadCoordinatorImpl.java b/src/main/java/org/torproject/descriptor/impl/DownloadCoordinatorImpl.java
index 331e7d9..23826aa 100644
--- a/src/main/java/org/torproject/descriptor/impl/DownloadCoordinatorImpl.java
+++ b/src/main/java/org/torproject/descriptor/impl/DownloadCoordinatorImpl.java
@@ -267,6 +267,9 @@ public class DownloadCoordinatorImpl implements DownloadCoordinator {
         if (response.getResponseCode() != 200) {
           this.missingVotes.add(requestedVote);
         }
+        break;
+      default:
+        /* nothing to be done */
     }
     if (response.getRequestEnd() != 0L) {
       this.descriptorQueue.add(response);
diff --git a/src/main/java/org/torproject/descriptor/impl/NetworkStatusImpl.java b/src/main/java/org/torproject/descriptor/impl/NetworkStatusImpl.java
index b6c274d..061a171 100644
--- a/src/main/java/org/torproject/descriptor/impl/NetworkStatusImpl.java
+++ b/src/main/java/org/torproject/descriptor/impl/NetworkStatusImpl.java
@@ -261,6 +261,11 @@ public abstract class NetworkStatusImpl extends DescriptorImpl {
         : new ArrayList<>(this.signatures);
   }
 
+  /**
+   * Implements method defined in
+   * {@link org.torproject.descriptor.RelayNetworkStatusConsensus}
+   * and {@link org.torproject.descriptor.RelayNetworkStatusVote}.
+   */
   public SortedMap<String, DirectorySignature> getDirectorySignatures() {
     SortedMap<String, DirectorySignature> directorySignatures = null;
     if (this.signatures != null) {



More information about the tor-commits mailing list