[tor-commits] [tor/master] prop250: Improve log messages

[nickm at torproject.org]

commit 63ca307127f70f2df3da20d50ecc545939658991
Author: David Goulet <dgoulet at torproject.org>
Date:   Tue May 17 15:05:32 2016 -0400

    prop250: Improve log messages
    
    Signed-off-by: David Goulet <dgoulet at torproject.org>
---
 src/or/shared_random.c       | 6 +++---
 src/or/shared_random_state.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/or/shared_random.c b/src/or/shared_random.c
index c5a62a7..15c33af 100644
--- a/src/or/shared_random.c
+++ b/src/or/shared_random.c
@@ -1102,8 +1102,8 @@ sr_parse_commit(const smartlist_t *args)
   rsa_identity_fpr = smartlist_get(args, 2);
   if (base16_decode(digest, DIGEST_LEN, rsa_identity_fpr,
                     HEX_DIGEST_LEN) < 0) {
-    log_warn(LD_DIR, "SR: RSA fingerprint '%s' not decodable",
-             rsa_identity_fpr);
+    log_warn(LD_DIR, "SR: RSA fingerprint %s not decodable",
+             escaped(rsa_identity_fpr));
     goto error;
   }
   /* Let's make sure, for extra safety, that this fingerprint is known to
@@ -1112,7 +1112,7 @@ sr_parse_commit(const smartlist_t *args)
   if (trusteddirserver_get_by_v3_auth_digest(digest) == NULL) {
     log_warn(LD_DIR, "SR: Fingerprint %s is not from a recognized "
                      "authority. Discarding commit.",
-             rsa_identity_fpr);
+             escaped(rsa_identity_fpr));
     goto error;
   }
 
diff --git a/src/or/shared_random_state.c b/src/or/shared_random_state.c
index 9700bf5..cce0c99 100644
--- a/src/or/shared_random_state.c
+++ b/src/or/shared_random_state.c
@@ -1122,7 +1122,7 @@ sr_state_update(time_t valid_after)
     char tbuf[ISO_TIME_LEN + 1];
     format_iso_time(tbuf, valid_after);
     log_info(LD_DIR, "SR: State prepared for new voting period (%s). "
-             "Current phase is %s (%d/%d).",
+             "Current phase is %s (%d commit & %d reveal rounds).",
              tbuf, get_phase_str(sr_state->phase),
              sr_state->n_commit_rounds, sr_state->n_reveal_rounds);
   }