[tor-commits] [metrics-web/master] Remove somewhat broken reset button.

karsten at torproject.org karsten at torproject.org
Wed Jan 20 11:55:34 UTC 2016


commit 1d52877a254c7826971a5e92d636ee23a41f6ab4
Author: Karsten Loesing <karsten.loesing at gmx.net>
Date:   Wed Jan 20 12:44:47 2016 +0100

    Remove somewhat broken reset button.
    
    Our reset button worked rather unintuitively.  When the user selects a
    previously unselected option and hits update, the page will reload
    with that option being selected.  Now, when the user hits reset,
    nothing happens, because all options are still unchanged as compared
    to what they were when reloading the page.  It seems we cannot fix
    this without using JavaScript.  But it also seems that users don't
    expect reset buttons these days, so let's just remove it rather than
    confusing users with it.
---
 website/web/WEB-INF/index.jsp |    1 -
 1 file changed, 1 deletion(-)

diff --git a/website/web/WEB-INF/index.jsp b/website/web/WEB-INF/index.jsp
index f2b9c3f..065f85a 100644
--- a/website/web/WEB-INF/index.jsp
+++ b/website/web/WEB-INF/index.jsp
@@ -51,7 +51,6 @@
 </c:forEach>
 </p>
 <p>
-<input type="reset" value="Reset">
 <input type="submit" value="Update">
 </p>
 </form>



More information about the tor-commits mailing list