[tor-commits] [tor/master] Silence clang-scan warnings in ed25519_donna

nickm at torproject.org nickm at torproject.org
Thu Feb 25 18:46:45 UTC 2016


commit 9ab1037de1c03b4a41186a1318674c2c3fa6d779
Author: teor (Tim Wilson-Brown) <teor2345 at gmail.com>
Date:   Wed Feb 24 23:24:01 2016 +0800

    Silence clang-scan warnings in ed25519_donna
---
 src/ext/ed25519/donna/ed25519_tor.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/ext/ed25519/donna/ed25519_tor.c b/src/ext/ed25519/donna/ed25519_tor.c
index ac726ba..52b259d 100644
--- a/src/ext/ed25519/donna/ed25519_tor.c
+++ b/src/ext/ed25519/donna/ed25519_tor.c
@@ -168,8 +168,8 @@ ed25519_donna_seckey_expand(unsigned char *sk, const unsigned char *skseed)
 int
 ed25519_donna_pubkey(unsigned char *pk, const unsigned char *sk)
 {
-  bignum256modm a;
-  ge25519 ALIGN(16) A;
+  bignum256modm a = {0};
+  ge25519 ALIGN(16) A = {{0}, {0}, {0}, {0}};
 
   /* A = aB */
   expand256_modm(a, sk, 32);
@@ -204,8 +204,8 @@ ed25519_donna_sign(unsigned char *sig, const unsigned char *m, size_t mlen,
   const unsigned char *sk, const unsigned char *pk)
 {
   ed25519_hash_context ctx;
-  bignum256modm r, S, a;
-  ge25519 ALIGN(16) R;
+  bignum256modm r = {0}, S, a;
+  ge25519 ALIGN(16) R = {{0}, {0}, {0}, {0}};
   hash_512bits hashr, hram;
 
   /* This is equivalent to the removed `ED25519_FN(ed25519_sign)` routine,





More information about the tor-commits mailing list