[tor-commits] [tor/master] Bitwise negate is ~, not !.

nickm at torproject.org nickm at torproject.org
Mon Feb 1 18:14:07 UTC 2016


commit c6fa55d2da728ab5abb8be82eba4c903c452516e
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Feb 1 13:12:58 2016 -0500

    Bitwise negate is ~, not !.
    
    Spotted by coverity; bug in tests only, not in any released Tor.
    
    This is CID 1351128
---
 src/test/test_routerlist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_routerlist.c b/src/test/test_routerlist.c
index 090a607..8c4254c 100644
--- a/src/test/test_routerlist.c
+++ b/src/test/test_routerlist.c
@@ -311,7 +311,7 @@ test_router_pick_directory_server_impl(void *arg)
   node_router3->rs->last_dir_503_at = 0;
 
   /* Set a Fascist firewall */
-  flags &= ! PDS_IGNORE_FASCISTFIREWALL;
+  flags &= ~ PDS_IGNORE_FASCISTFIREWALL;
   policy_line = tor_malloc_zero(sizeof(config_line_t));
   policy_line->key = tor_strdup("ReachableORAddresses");
   policy_line->value = tor_strdup("accept *:442, reject *:*");



More information about the tor-commits mailing list