[tor-commits] [sandboxed-tor-browser/master] Bug 20970: Firefox crashes if the security slider is left at the default on certian pages.

[yawning at torproject.org]

commit db42366aabfd4ed975e34197a09a4a6fff4aa322
Author: Yawning Angel <yawning at schwanenlied.me>
Date:   Wed Dec 14 23:29:13 2016 +0000

    Bug 20970: Firefox crashes if the security slider is left at the default on certian pages.
    
    Bump up the stack rlimit() from 512 KiB to 8 MiB.  This is probably
    higher than it needs to be, but until I get a better feel for how much
    stack space firefox consumes, something that is a typical default should
    be fine here.
---
 ChangeLog                                                | 2 ++
 src/cmd/sandboxed-tor-browser/internal/sandbox/rlimit.go | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 127ea5b..ed63781 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,6 @@
 Changes in version 0.0.3 - UNRELEASED:
+ * Bug 20970: Firefox crashes if the security slider is left at the default
+   on certain pages.
  * Bug 20973: Silence Gdk warnings on systems with integrated png loader.
  * Bug 20806: Try even harder to exclude gstreamer.
  * Per the browser developers, the initial 7.0 alpha builds will not be ESR52
diff --git a/src/cmd/sandboxed-tor-browser/internal/sandbox/rlimit.go b/src/cmd/sandboxed-tor-browser/internal/sandbox/rlimit.go
index 9ac9aed..46cb2c2 100644
--- a/src/cmd/sandboxed-tor-browser/internal/sandbox/rlimit.go
+++ b/src/cmd/sandboxed-tor-browser/internal/sandbox/rlimit.go
@@ -48,7 +48,7 @@ func lowerRlimit(resource int, newHard uint64) error {
 // because it should be tied into the UI.
 func SetSensibleRlimits() error {
 	const (
-		limStack      = 512 * 1024 // 512 KiB
+		limStack      = 8 * 1024 * 1024 // 8 MiB Firefox uses a lot with js...
 		limRSS        = 0          // No effect as of 2.6.x...
 		limNproc      = 512
 		limNofile     = 1024 // Could maybe go as low as 512...