[tor-commits] [tor/master] Fix a couple more crypto_digest() calls to be explicit < 0

nickm at torproject.org nickm at torproject.org
Mon Dec 5 15:32:49 UTC 2016


commit 41adfd6fa38bf94bc7d71174dbaf7f32a41a64ec
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Dec 5 10:31:31 2016 -0500

    Fix a couple more crypto_digest() calls to be explicit < 0
---
 src/or/routerparse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index f3246c9..38ceb94 100644
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -715,7 +715,7 @@ dump_desc_populate_one_file, (const char *dirname, const char *f))
    * filename.
    */
   if (crypto_digest256((char *)content_digest, desc, (size_t) st.st_size,
-                       DIGEST_SHA256) != 0) {
+                       DIGEST_SHA256) < 0) {
     /* Weird, but okay */
     log_info(LD_DIR,
              "Unable to hash content of %s from unparseable descriptors "
@@ -879,7 +879,7 @@ dump_desc(const char *desc, const char *type)
   /* Get the hash for logging purposes anyway */
   len = strlen(desc);
   if (crypto_digest256((char *)digest_sha256, desc, len,
-                       DIGEST_SHA256) != 0) {
+                       DIGEST_SHA256) < 0) {
     log_info(LD_DIR,
              "Unable to parse descriptor of type %s, and unable to even hash"
              " it!", type);



More information about the tor-commits mailing list