[tor-commits] [tor/master] test_single_onion_poisoning: Free dir[12] on all paths

nickm at torproject.org nickm at torproject.org
Fri Dec 2 12:41:06 UTC 2016


commit 1221c5aa02c0a9789de92d16935cf74da5365822
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Dec 2 07:39:14 2016 -0500

    test_single_onion_poisoning: Free dir[12] on all paths
    
    Coverity doesn't like it when there are paths to the end of the
    function where something doesn't get freed, even when those paths
    are only reachable on unit test failure.
    
    Fixes CID 1372899 and CID 1372900. Bug not in any released Tor.
---
 src/test/test_hs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/test/test_hs.c b/src/test/test_hs.c
index fc8ce97..f4ba7f9 100644
--- a/src/test/test_hs.c
+++ b/src/test/test_hs.c
@@ -765,6 +765,8 @@ test_single_onion_poisoning(void *arg)
   tt_assert(ret == 0);
 
  done:
+  tor_free(dir1);
+  tor_free(dir2);
   /* The test harness deletes the directories at exit */
   smartlist_free(services);
   rend_service_free(service_1);





More information about the tor-commits mailing list