[tor-commits] [collector/master] Make checkstyle task fail, when new warnings appear.

karsten at torproject.org karsten at torproject.org
Tue Aug 2 18:10:18 UTC 2016


commit f2d0cf0b9f2acdb0bd96e39d3f7b55d458eb154a
Author: iwakeh <iwakeh at torproject.org>
Date:   Tue Aug 2 16:58:38 2016 +0200

    Make checkstyle task fail, when new warnings appear.
---
 build.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/build.xml b/build.xml
index 643d94c..d21726e 100644
--- a/build.xml
+++ b/build.xml
@@ -196,6 +196,17 @@
       <formatter type="plain"
                  toFile="${generated}/checkstyle_report.txt"/>
     </checkstyle>
+    <exec executable="cat" outputproperty="checkstyle.result">
+      <arg value="${generated}/checkstyle_report.txt" />
+    </exec>
+    <fail message="Checkstyle complaints: ${checkstyle.result}" >
+      <condition>
+        <not>
+          <length string="${checkstyle.result}"
+                  length="29" />
+        </not>
+      </condition>
+    </fail>
   </target>
   <taskdef classpathref="cobertura.classpath" resource="tasks.properties" />
   <target name="coverage" depends="compile,compile-tests">



More information about the tor-commits mailing list