[tor-commits] [snowflake/master] remove more dead code from broker

arlo at torproject.org arlo at torproject.org
Tue Apr 5 17:29:43 UTC 2016


commit 0f952408d329f8a54a475eb833afd109e079e51f
Author: Serene Han <keroserene+git at gmail.com>
Date:   Sat Apr 2 21:50:26 2016 -0700

    remove more dead code from broker
---
 broker/broker.go | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/broker/broker.go b/broker/broker.go
index 21777bd..ffeabdd 100644
--- a/broker/broker.go
+++ b/broker/broker.go
@@ -2,10 +2,6 @@
 Broker acts as the HTTP signaling channel.
 It matches clients and snowflake proxies by passing corresponding
 SessionDescriptions in order to negotiate a WebRTC connection.
-
-TODO(serene): This code is currently the absolute minimum required to
-cause a successful negotiation.
-It's otherwise very unsafe and problematic, and needs quite some work...
 */
 package snowflake_broker
 
@@ -82,8 +78,6 @@ func (ctx *BrokerContext) RequestOffer(id string) []byte {
 func (ctx *BrokerContext) Broker() {
 	for request := range ctx.proxyPolls {
 		snowflake := ctx.AddSnowflake(request.id)
-		// defer heap.Remove(ctx.snowflakes, snowflake.index)
-		// defer delete(ctx.idToSnowflake, snowflake.id)
 		// Wait for a client to avail an offer to the snowflake.
 		go func(request *ProxyPoll) {
 			select {



More information about the tor-commits mailing list