[tor-commits] [nyx/master] Sorting by country referenced non-existant function

atagar at torproject.org atagar at torproject.org
Tue Sep 22 17:08:40 UTC 2015


commit f514d1ee9687b63ce72953946d2683aeb4e440ea
Author: Damian Johnson <atagar at torproject.org>
Date:   Sat Aug 29 14:24:28 2015 -0700

    Sorting by country referenced non-existant function
    
    Calls is_private_address() on connections. This isn't a thing. Pretty clear
    what it's trying to do, though.
---
 nyx/connections/entries.py |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/nyx/connections/entries.py b/nyx/connections/entries.py
index f0b06d3..70ca6ac 100644
--- a/nyx/connections/entries.py
+++ b/nyx/connections/entries.py
@@ -158,10 +158,7 @@ class ConnectionPanelEntry:
     elif attr == SortAttr.UPTIME:
       return self._start_time
     elif attr == SortAttr.COUNTRY:
-      if connection_line.connection.is_private_address(self.lines[0].connection.remote_address):
-        return ''
-      else:
-        return connection_line.get_locale('')
+      return '' if self.is_private() else connection_line.get_locale('')
     else:
       return ''
 





More information about the tor-commits mailing list