[tor-commits] [tor/master] Fix a false-positive in coverity scan with an assertion

nickm at torproject.org nickm at torproject.org
Tue Sep 1 13:52:46 UTC 2015


commit b977a570c4fea136910fb9f41fd57b9ba3e34699
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Sep 1 09:50:33 2015 -0400

    Fix a false-positive in coverity scan with an assertion
    
    CID 1301373
---
 src/or/routerkeys.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/or/routerkeys.c b/src/or/routerkeys.c
index 1bf0951..50659fc 100644
--- a/src/or/routerkeys.c
+++ b/src/or/routerkeys.c
@@ -295,6 +295,7 @@ ed_key_init_from_file(const char *fname, uint32_t flags,
     if (rv == 0) {
       have_secret = 1;
       loaded_secret_fname = secret_fname;
+      tor_assert(got_tag);
     } else {
       if (errno != ENOENT && norepair) {
         tor_log(severity, LD_OR, "Unable to read %s: %s", secret_fname,



More information about the tor-commits mailing list