[tor-commits] [bridgedb/master] Remove the insanely chatty log messages about miscalculated hashrings.

isis at torproject.org isis at torproject.org
Fri May 1 07:10:57 UTC 2015


commit 78c3df98888252a2045e1e627397ec8e1f7a3f4c
Author: Isis Lovecruft <isis at torproject.org>
Date:   Sat Mar 28 02:32:55 2015 +0000

    Remove the insanely chatty log messages about miscalculated hashrings.
    
    I added these earlier this week for debugging purposes, but it turns out
    that they print *so* many times that it is impossible to follow the
    logfiles.
---
 lib/bridgedb/Filters.py |   14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/lib/bridgedb/Filters.py b/lib/bridgedb/Filters.py
index b857967..b06a605 100644
--- a/lib/bridgedb/Filters.py
+++ b/lib/bridgedb/Filters.py
@@ -24,12 +24,7 @@ def filterAssignBridgesToRing(hmac, numRings, assignedRing):
 
             if which == assignedRing:
                 return True
-            else:
-                logging.debug(("Bridge %s has calculated assignment %d; not "
-                               "in correct ring %d.")
-                              % (bridge, which, assignedRing))
-                return False
-
+            return False
         _assignBridgesToRing.__name__ = ("filterAssignBridgesToRing(%s, %s, %s)"
                                          % (hmac, numRings, assignedRing))
         setattr(_assignBridgesToRing, "description", "ring=%d" % assignedRing)
@@ -88,13 +83,6 @@ def filterBridgesByTransport(methodname, addressClass=None):
                     # ignore method name case
                     if transport.methodname.lower() == methodname.lower():
                         return True
-                    else:
-                        logging.debug(("Transport methodname '%s' doesn't match "
-                                       "requested methodname: '%s'.")
-                                      % (transport.methodname, methodname))
-                else:
-                    logging.debug(("Transport %s has incorrect address version "
-                                   "(%s).") % (transport, addressClass))
             return False
 
         _filterByTransport.__name__ = ("filterBridgesByTransport(%s,%s)"





More information about the tor-commits mailing list