[tor-commits] [tor/master] Put an upper bound on test_workqueue -I argument

nickm at torproject.org nickm at torproject.org
Tue Mar 24 14:50:59 UTC 2015


commit 8f951d019656ecdc49f2b944781539c40e1a8392
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Mar 24 10:49:29 2015 -0400

    Put an upper bound on test_workqueue -I argument
    
    This makes coverity happy, since it doesn't like us looping against
    a value which might be INT_MAX.
    
    This is CID 1268069
---
 src/test/test_workqueue.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/test/test_workqueue.c b/src/test/test_workqueue.c
index aaff506..83f6f3e 100644
--- a/src/test/test_workqueue.c
+++ b/src/test/test_workqueue.c
@@ -18,6 +18,8 @@
 #include <event.h>
 #endif
 
+#define MAX_INFLIGHT (1<<16)
+
 static int opt_verbose = 0;
 static int opt_n_threads = 8;
 static int opt_n_items = 10000;
@@ -348,7 +350,7 @@ main(int argc, char **argv)
   }
   if (opt_n_threads < 1 ||
       opt_n_items < 1 || opt_n_inflight < 1 || opt_n_lowwater < 0 ||
-      opt_n_cancel > opt_n_inflight ||
+      opt_n_cancel > opt_n_inflight || opt_n_inflight > MAX_INFLIGHT ||
       opt_ratio_rsa < 0) {
     help();
     return 1;



More information about the tor-commits mailing list