[tor-commits] [bridgedb/master] Add comment to note that Stem also checks nickname spec conformity.

isis at torproject.org isis at torproject.org
Sat Mar 21 02:02:59 UTC 2015


commit 842a1e26a15b83eb563671bb0929fe7a7e0f2e6e
Author: Isis Lovecruft <isis at torproject.org>
Date:   Sun Dec 28 12:26:06 2014 +0000

    Add comment to note that Stem also checks nickname spec conformity.
---
 lib/bridgedb/bridges.py |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/bridgedb/bridges.py b/lib/bridgedb/bridges.py
index 4327f28..5aa801e 100644
--- a/lib/bridgedb/bridges.py
+++ b/lib/bridgedb/bridges.py
@@ -503,10 +503,13 @@ class BridgeBase(BridgeAddressBase):
     def nickname(self, value):
         """Set this Bridge's nickname to **value**.
 
+        .. note:: We don't need to call
+            :func:`bridgedb.parse.nickname.isValidRouterNickname() since Stem
+            will check nickname specification conformity.
+
         :param str value: The nickname of this Bridge.
         """
-        if isValidRouterNickname(value):
-            self._nickname = value
+        self._nickname = value
 
     @nickname.deleter
     def nickname(self, value):





More information about the tor-commits mailing list