[tor-commits] [bridgedb/master] Add two unittest for _copyUnparseableDescriptorFile().

[isis at torproject.org]

commit afd6e55820f674756bef28c9f436b90d949276fd
Author: Isis Lovecruft <isis at torproject.org>
Date:   Fri Dec 5 09:35:40 2014 +0000

    Add two unittest for _copyUnparseableDescriptorFile().
---
 lib/bridgedb/test/test_parse_descriptors.py |   37 +++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/lib/bridgedb/test/test_parse_descriptors.py b/lib/bridgedb/test/test_parse_descriptors.py
index 0b81dd7..d867768 100644
--- a/lib/bridgedb/test/test_parse_descriptors.py
+++ b/lib/bridgedb/test/test_parse_descriptors.py
@@ -536,3 +536,40 @@ class ParseDescriptorsTests(unittest.TestCase):
         routers = descriptors.parseBridgeExtraInfoFiles(io.BytesIO(''))
         self.assertIsInstance(routers, dict)
         self.assertEqual(len(routers), 0)
+
+    def test_parse_descriptors_copyUnparseableDescriptorFile_return_value(self):
+        """``b.p.descriptors._copyUnparseableDescriptorFile()`` should return
+        True when the new file is successfully created.
+        """
+        filename = "bridge-descriptors"
+        with open(filename, 'w') as fh:
+            fh.write(BRIDGE_SERVER_DESCRIPTOR)
+            fh.flush()
+
+        result = descriptors._copyUnparseableDescriptorFile(filename)
+        self.assertTrue(result)  # should return True
+
+    def test_parse_descriptors_copyUnparseableDescriptorFile_new_filename(self):
+        """``b.p.descriptors._copyUnparseableDescriptorFile()`` should create a
+        copy of the bad file with a specific filename format.
+        """
+        filename = "bridge-descriptors"
+        with open(filename, 'w') as fh:
+            fh.write(BRIDGE_SERVER_DESCRIPTOR)
+            fh.flush()
+
+        descriptors._copyUnparseableDescriptorFile(filename)
+        matchingFiles = glob.glob("*_bridge-descriptors.unparseable")
+        self.assertEqual(len(matchingFiles), 1)
+
+        newFile = matchingFiles[-1]
+        self.assertTrue(os.path.isfile(newFile))
+
+        timestamp = datetime.datetime.strptime(newFile.split("_")[0],
+                                               "%Y-%m-%d-%H:%M:%S")
+        # The timestamp should be roughly today (unless we just passed
+        # midnight, then it might be +/- 1):
+        self.assertApproximates(timestamp.now().day, timestamp.day, 1)
+
+        # The timestamp should be roughly this hour (+/- 1):
+        self.assertApproximates(timestamp.now().hour, timestamp.hour, 1)