[tor-commits] [bridgedb/develop] Remove annoying and unnecessary log statements with memory addresses.

isis at torproject.org isis at torproject.org
Thu Jun 25 03:13:29 UTC 2015

commit dfbc8e0abbfba32324c4c2c9573d0671a150cf34
Author: Isis Lovecruft <isis at torproject.org>
Date:   Mon Apr 20 22:27:05 2015 +0000

    Remove annoying and unnecessary log statements with memory addresses.
    The information which these log statements were trying to log is
    captured by other log statements within the same functions, and both of
    them included non-human-useful data like locations of various objects in
 lib/bridgedb/Bridges.py |    3 ---
 lib/bridgedb/Filters.py |    1 -
 2 files changed, 4 deletions(-)

diff --git a/lib/bridgedb/Bridges.py b/lib/bridgedb/Bridges.py
index 58a81cd..d9b28e2 100644
--- a/lib/bridgedb/Bridges.py
+++ b/lib/bridgedb/Bridges.py
@@ -634,9 +634,6 @@ class FilteredBridgeSplitter(BridgeHolder):
         # I suppose since it contains memory addresses, it *is* technically
         # likely to be a unique string, but it is messy.
-        logging.debug("Adding '%s' subring to %s..."
-                      % (ringname, self.__class__.__name__))
         if not isinstance(subring, BridgeHolder):
             logging.fatal("%s hashring can't add invalid subring: %r"
                           % (self.distributorName, subring))
diff --git a/lib/bridgedb/Filters.py b/lib/bridgedb/Filters.py
index eadf012..aade069 100644
--- a/lib/bridgedb/Filters.py
+++ b/lib/bridgedb/Filters.py
@@ -12,7 +12,6 @@ def filterAssignBridgesToRing(hmac, numRings, assignedRing):
     # ruleset ensures that the same 
     logging.debug("Creating a filter for assigning bridges to hashrings...")
     ruleset = frozenset([hmac, numRings, assignedRing]) 
-    logging.debug("Filter created: %s" % ruleset)
         return funcs[ruleset]

More information about the tor-commits mailing list