[tor-commits] [stem/master] Ignore pyflake false alarms for python2/3 compatability

atagar at torproject.org atagar at torproject.org
Sun Feb 1 20:19:19 UTC 2015


commit 4402a7bfc8d56178af60c32ad36b1ca82d05e659
Author: Damian Johnson <atagar at torproject.org>
Date:   Sun Feb 1 12:17:06 2015 -0800

    Ignore pyflake false alarms for python2/3 compatability
    
    We have a few 'if python2 do X, if python3 do Y' spots to have compatability
    with both versions. Pyflakes understandably complained about not having long,
    unicode, or raw_input under python3...
    
      https://trac.torproject.org/projects/tor/ticket/14559
    
    Adding these to our ignore pattern. Now running the tests under python3 with
    pyflakes and pep8 the static checks pass.
---
 test/settings.cfg |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/settings.cfg b/test/settings.cfg
index 2cbdd0a..c4999fb 100644
--- a/test/settings.cfg
+++ b/test/settings.cfg
@@ -132,11 +132,14 @@ pep8.ignore E131
 # issue.
 
 pyflakes.ignore run_tests.py => 'unittest' imported but unused
+pyflakes.ignore stem/__init__.py => undefined name 'long'
+pyflakes.ignore stem/__init__.py => undefined name 'unicode'
 pyflakes.ignore stem/control.py => undefined name 'controller'
 pyflakes.ignore stem/prereq.py => 'RSA' imported but unused
 pyflakes.ignore stem/prereq.py => 'asn1' imported but unused
 pyflakes.ignore stem/prereq.py => 'unittest' imported but unused
 pyflakes.ignore stem/prereq.py => 'long_to_bytes' imported but unused
+pyflakes.ignore stem/interpreter/__init__.py => undefined name 'raw_input'
 pyflakes.ignore stem/util/test_tools.py => 'pyflakes' imported but unused
 pyflakes.ignore stem/util/test_tools.py => 'pep8' imported but unused
 pyflakes.ignore test/mocking.py => undefined name 'test'



More information about the tor-commits mailing list