[tor-commits] [tor/master] Use variables instead of substitutions

nickm at torproject.org nickm at torproject.org
Mon Dec 14 18:21:31 UTC 2015


commit 01a9575ad049643656254911167da901f0f7b04c
Author: cypherpunks <cypherpunks at torproject.org>
Date:   Fri Dec 11 23:51:17 2015 +0100

    Use variables instead of substitutions
    
    Using variables removes the ambiguity about when to use variables and
    when to use substitutions. Variables always work. Substitutions only
    work when Autoconf knows about them which is not always the case.
    
    The variables are also placed between quotes to ensures spaces in the
    variables are handled properly.
---
 src/test/include.am |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/test/include.am b/src/test/include.am
index a24c5bb..9577e1e 100644
--- a/src/test/include.am
+++ b/src/test/include.am
@@ -1,8 +1,8 @@
 AM_TESTS_ENVIRONMENT = \
-	export PYTHON=@PYTHON@; \
-	export SHELL=@SHELL@; \
-	export abs_top_srcdir=@abs_top_srcdir@; \
-	export builddir=@builddir@; \
+	export PYTHON="$(PYTHON)"; \
+	export SHELL="$(SHELL)"; \
+	export abs_top_srcdir="$(abs_top_srcdir)"; \
+	export builddir="$(builddir)"; \
 	export TESTING_TOR_BINARY="$(TESTING_TOR_BINARY)";
 
 TESTSCRIPTS = src/test/test_zero_length_keys.sh





More information about the tor-commits mailing list