[tor-commits] [stem/master] Static check citing duplicate 'test'

atagar at torproject.org atagar at torproject.org
Fri Apr 24 16:01:41 UTC 2015


commit 888488f3ea25ca71b71e34c8add5bb5f3a5a472e
Author: Damian Johnson <atagar at torproject.org>
Date:   Fri Apr 24 09:04:34 2015 -0700

    Static check citing duplicate 'test'
    
    This one I can't repro here but on another system saw...
    
      STATIC CHECKS
    
      * /tmp/stem/test/util.py
      line 130  - redefinition of unused 'test' from line 42 test = module_prefix.rsplit('.', 1)[1]
    
    Trivial to sidestep.
---
 test/util.py |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/util.py b/test/util.py
index 87fc47e..533dcc8 100644
--- a/test/util.py
+++ b/test/util.py
@@ -127,8 +127,8 @@ def _get_tests(modules, module_prefix):
       elif module_prefix.startswith(module):
         # single test for this module
 
-        test = module_prefix.rsplit('.', 1)[1]
-        yield '%s.%s' % (import_name, test)
+        test_module = module_prefix.rsplit('.', 1)[1]
+        yield '%s.%s' % (import_name, test_module)
 
 
 def get_prereq(target):



More information about the tor-commits mailing list