[tor-commits] [tor/master] Use correct severity in the get_if_addrs tests.

nickm at torproject.org nickm at torproject.org
Thu Apr 23 13:03:10 UTC 2015


commit 9a9ab455a3e1629f84ae3fc1c5af2fc7e41b1107
Author: Yawning Angel <yawning at schwanenlied.me>
Date:   Tue Apr 21 16:42:07 2015 +0000

    Use correct severity in the get_if_addrs tests.
---
 changes/bug15759        |    6 ++++++
 src/test/test_address.c |    4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/changes/bug15759 b/changes/bug15759
new file mode 100644
index 0000000..24c5eb0
--- /dev/null
+++ b/changes/bug15759
@@ -0,0 +1,6 @@
+  o Minor bugfixes (testing):
+    - Set the severity correctly when testing get_interface_addresses_ifaddrs()
+      and get_interface_addresses_win32(), so that the tests fail gracefully
+      instead of triggering an assertion. Fixes bug 15759; bugfix on
+      0.2.6.3-alpha. Reported by Nicolas Derive.
+
diff --git a/src/test/test_address.c b/src/test/test_address.c
index 5236162..d13d678 100644
--- a/src/test/test_address.c
+++ b/src/test/test_address.c
@@ -222,7 +222,7 @@ test_address_get_if_addrs_ifaddrs(void *arg)
 
   (void)arg;
 
-  results = get_interface_addresses_ifaddrs(0);
+  results = get_interface_addresses_ifaddrs(LOG_ERR);
 
   tt_int_op(smartlist_len(results),>=,1);
   tt_assert(smartlist_contains_localhost_tor_addr(results));
@@ -245,7 +245,7 @@ test_address_get_if_addrs_win32(void *arg)
 
   (void)arg;
 
-  results = get_interface_addresses_win32(0);
+  results = get_interface_addresses_win32(LOG_ERR);
 
   tt_int_op(smartlist_len(results),>=,1);
   tt_assert(smartlist_contains_localhost_tor_addr(results));





More information about the tor-commits mailing list