[tor-commits] [tor/master] Update entrynodes unit test for dirs

nickm at torproject.org nickm at torproject.org
Wed Apr 1 19:18:45 UTC 2015


commit e10e6f78b17395ce6f3c341c1efd6da671c7c00c
Author: Sebastian Hahn <sebastian at torproject.org>
Date:   Wed Apr 1 21:08:24 2015 +0200

    Update entrynodes unit test for dirs
    
    We no longer base our opinion on whether someone is a directory solely
    on the routerstatus we might have for that relay, but also on a
    routerinfo. Remove logic in test checking that. This broke unit tests in
    05f7336624d6a47b3cf0f.
    
    Reported by toralf on #tor-dev, thanks!
---
 src/test/test_entrynodes.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/test/test_entrynodes.c b/src/test/test_entrynodes.c
index 17cb9d9..0011d36 100644
--- a/src/test/test_entrynodes.c
+++ b/src/test/test_entrynodes.c
@@ -162,9 +162,6 @@ populate_live_entry_guards_test_helper(int num_needed)
        False, all guards should have made_contact enabled. */
     tt_int_op(entry->made_contact, OP_EQ, 1);
 
-    /* Since we don't have a routerstatus, all of the entry guards are
-       not directory servers. */
-    tt_int_op(entry->is_dir_cache, OP_EQ, 0);
   } SMARTLIST_FOREACH_END(entry);
 
   /* First, try to get some fast guards. This should fail. */



More information about the tor-commits mailing list