[tor-commits] [tor/master] Remove extra newline at the end of HS descriptor

nickm at torproject.org nickm at torproject.org
Wed Apr 1 16:52:09 UTC 2015

commit c9534f7902fa222f2076136f460b13689d75ab41
Author: David Goulet <dgoulet at ev0ke.net>
Date:   Mon Mar 16 09:04:51 2015 -0400

    Remove extra newline at the end of HS descriptor
    The rend-spec.txt document doesn't specify this extra newline. Furthermore,
    this is the only descryptor type that contains one. Client and HSDir without
    this patch still work perfectly since the HS descriptor parsing doesn't
    expect a newline at the end.
    Fixes #15296
    Signed-off-by: David Goulet <dgoulet at ev0ke.net>
 src/or/rendcommon.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/src/or/rendcommon.c b/src/or/rendcommon.c
index 866f4fb..174f1c4 100644
--- a/src/or/rendcommon.c
+++ b/src/or/rendcommon.c
@@ -646,7 +646,6 @@ rend_encode_v2_descriptors(smartlist_t *descs_out,
         goto err;
-    desc_str[written++] = '\n';
     desc_str[written++] = 0;
     /* Check if we can parse our own descriptor. */
     if (!rend_desc_v2_is_parsable(enc)) {

More information about the tor-commits mailing list