[tor-commits] [tor/master] Clarify 13476 changelog (From sebastian)

nickm at torproject.org nickm at torproject.org
Thu Oct 30 13:56:37 UTC 2014

commit 5a601dd2901644a537621f407f072d634ece2cfe
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Oct 30 09:56:40 2014 -0400

    Clarify 13476 changelog (From sebastian)
 ChangeLog |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 00a3e9c..4f3b230 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -142,9 +142,11 @@ Changes in version - 2014-10-30
     - Check all date/time values passed to tor_timegm and
       parse_rfc1123_time for validity, taking leap years into account.
       Improves HTTP header validation. Implemented with bug 13476.
-    - Clamp year values returned by system localtime(_r) and gmtime(_r)
-      to year 1 in correct_tm. This ensures tor can read any values it
-      writes out. Fixes bug 13476.
+    - In correct_tm(), limit the range of values returned by system
+      localtime(_r) and gmtime(_r) to be between the years 1 and 8099.
+      This means we don't have to deal with negative or too large dates,
+      even if a clock is wrong. Otherwise we might fail to read a file
+      written by us which includes such a date. Fixes bug 13476.
   o Minor bugfixes (bridge clients):
     - When configured to use a bridge without an identity digest (not

More information about the tor-commits mailing list