[tor-commits] [tor/master] Additional test for error-case

[nickm at torproject.org]

commit 3d0d49be230a8720ebdadf668b993f8ba2c5b2ca
Author: meejah <meejah at meejah.ca>
Date:   Wed Oct 15 02:17:54 2014 -0600

    Additional test for error-case
    
    This error-case was already fixed by previous changes,
    this is to cover it in case there's a regression.
---
 src/test/test_checkdir.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/test/test_checkdir.c b/src/test/test_checkdir.c
index 1580e62..7bf735e 100644
--- a/src/test/test_checkdir.c
+++ b/src/test/test_checkdir.c
@@ -43,6 +43,14 @@ test_checkdir_perms(void *testdata)
   tt_int_op(0, ==, (st.st_mode & unix_verify_optsmask));
   tor_free(testdir);
 
+  /* test: should get an error on existing dir with
+           wrong perms */
+  testdir = get_datadir_fname("checkdir_new_groupok_err");
+  tt_int_op(0, ==, mkdir(testdir, 027));
+  cpd_chkopts = CPD_CHECK_MODE_ONLY|CPD_CREATE|CPD_GROUP_OK;
+  tt_int_op(-1, ==, check_private_dir(testdir, cpd_chkopts, NULL));
+  tor_free(testdir);
+
   /* test: create new dir, CPD_GROUP_READ option set. */
   testdir = get_datadir_fname("checkdir_new_groupread");
   cpd_chkopts = CPD_CREATE|CPD_GROUP_READ;