[tor-commits] [tor/master] Fix cross-compiling when 128-bit math compiles but won't link

nickm at torproject.org nickm at torproject.org
Mon May 5 15:45:34 UTC 2014


commit 388478561dd4457afedf530591f02cb05864b187
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon May 5 11:44:02 2014 -0400

    Fix cross-compiling when 128-bit math compiles but won't link
    
    Apparently, there exist cross-compiling environments for arm7 where
    you can compile a 64x64->128 multiply, but not link it.
    
    Fixes bug 11729; bugfix on 0.2.4.8-alpha. Patch from 'conradev'.
---
 changes/bug11729 |    5 +++++
 configure.ac     |    2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/changes/bug11729 b/changes/bug11729
new file mode 100644
index 0000000..93751cf
--- /dev/null
+++ b/changes/bug11729
@@ -0,0 +1,5 @@
+  o Minor bugfixes (build):
+    - When deciding whether to build the 64-bit curve25519 implementation,
+      detect platforms where we can compile 128-bit arithmetic but cannot
+      link it. Fixes bug 11729; bugfix on 0.2.4.8-alpha. Patch
+      from "conradev".
diff --git a/configure.ac b/configure.ac
index 3ef5cdd..a96a333 100644
--- a/configure.ac
+++ b/configure.ac
@@ -770,7 +770,7 @@ if test x$enable_curve25519 != xno; then
         ])],
 	[tor_cv_can_use_curve25519_donna_c64=yes],
         [tor_cv_can_use_curve25519_donna_c64=no],
-	[AC_COMPILE_IFELSE(
+	[AC_LINK_IFELSE(
           [AC_LANG_PROGRAM([dnl
         #include <stdint.h>
         typedef unsigned uint128_t __attribute__((mode(TI)));



More information about the tor-commits mailing list