[tor-commits] [tor/master] Downgrade bug 7164 warning to INFO

nickm at torproject.org nickm at torproject.org
Thu May 1 15:46:23 UTC 2014


commit 6a4f5d9b4df1d05d1b158417cfcc85a547ad1549
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu May 1 11:42:02 2014 -0400

    Downgrade bug 7164 warning to INFO
    
    The 0.2.5.x warning is the one that might help us track this down; the
    warnings in stable are just annoying users over and over and over.
---
 changes/bug7164_downgrade |    6 ++++++
 src/or/microdesc.c        |    2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/changes/bug7164_downgrade b/changes/bug7164_downgrade
new file mode 100644
index 0000000..4d75586
--- /dev/null
+++ b/changes/bug7164_downgrade
@@ -0,0 +1,6 @@
+  o Minor bugfixes:
+    - Downgrade the warning severity for the the "md was still referenced 1
+      node(s)" warning. Tor 0.2.5.4-alpha has better code for trying to
+      diagnose this bug, and the current warning in earlier versions of
+      tor achieves nothing useful. Addresses warning from bug 7164.
+
diff --git a/src/or/microdesc.c b/src/or/microdesc.c
index b4d22c1..4acec6a 100644
--- a/src/or/microdesc.c
+++ b/src/or/microdesc.c
@@ -561,7 +561,7 @@ microdesc_free(microdesc_t *md)
         }
       });
     if (found) {
-      log_warn(LD_BUG, "microdesc_free() called, but md was still referenced "
+      log_info(LD_BUG, "microdesc_free() called, but md was still referenced "
                "%d node(s); held_by_nodes == %u", found, md->held_by_nodes);
     } else {
       log_warn(LD_BUG, "microdesc_free() called with held_by_nodes set to %u, "





More information about the tor-commits mailing list