[tor-commits] [bridgedb/master] Remove line that duplicated setting the flags in parseSLine().

isis at torproject.org isis at torproject.org
Sun Jan 12 06:06:34 UTC 2014


commit 9fc6aaed3140020cce4f42b06b23d7b533c5aa93
Author: Isis Lovecruft <isis at torproject.org>
Date:   Fri Nov 22 01:19:58 2013 +0000

    Remove line that duplicated setting the flags in parseSLine().
    
    The lines following this one (i.e. ``stable = 'Stable' in flags``)
    ensure that if a particular flags isn't present in the flags, then the
    variable is false; there is no need to set each variable twice.
    
     * REMOVE duplicate variable instantiation/setting from
       bridgedb.parse.networkstatus.parseSLine() function.
---
 lib/bridgedb/parse/networkstatus.py |    2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/bridgedb/parse/networkstatus.py b/lib/bridgedb/parse/networkstatus.py
index a367b03..a20ddb4 100644
--- a/lib/bridgedb/parse/networkstatus.py
+++ b/lib/bridgedb/parse/networkstatus.py
@@ -246,8 +246,6 @@ def parseSLine(line):
     :returns: A 2-tuple of booleans, the first is True if the bridge has the
         "Running" flag, and the second is True if it has the "Stable" flag.
     """
-    fast, running, stable, guard, valid = False
-    
     line = line[2:]
 
     flags = [x.capitalize() for x in line.split()]





More information about the tor-commits mailing list