[tor-commits] [stem/master] New succinct test output reported errors as successes

atagar at torproject.org atagar at torproject.org
Mon Jan 6 05:55:32 UTC 2014


commit 6837752b4c5d7f74bef8be0bca8c8fc7f6f3e8f7
Author: Damian Johnson <atagar at torproject.org>
Date:   Sun Jan 5 21:50:40 2014 -0800

    New succinct test output reported errors as successes
    
    We reported failures as failures but didn't interpret errors as failures as
    well.
---
 run_tests.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/run_tests.py b/run_tests.py
index 5450dea..f28ab8e 100755
--- a/run_tests.py
+++ b/run_tests.py
@@ -449,7 +449,7 @@ def _run_test(args, test_class, output_filters, logging_buffer):
   if args.verbose:
     sys.stdout.write(test.output.apply_filters(test_results.getvalue(), *output_filters))
     println()
-  elif not run_result.failures:
+  elif not run_result.failures and not run_result.errors:
     println(" success (%0.2fs)" % (time.time() - start_time), SUCCESS)
   else:
     println(" failed (%0.2fs)" % (time.time() - start_time), ERROR)





More information about the tor-commits mailing list