[tor-commits] [arm/master] Including run_tests.py among our static checks

atagar at torproject.org atagar at torproject.org
Thu Jan 2 17:12:04 UTC 2014


commit f31be2db56bec8284d7b91a36bca7a8d61242904
Author: Damian Johnson <atagar at torproject.org>
Date:   Thu Jan 2 08:43:01 2014 -0800

    Including run_tests.py among our static checks
    
    Oops, also including our run_tests.py when running pyflakes and pep8.
---
 run_tests.py      |    6 +++---
 test/settings.cfg |    2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/run_tests.py b/run_tests.py
index 13570bc..db7fd1d 100755
--- a/run_tests.py
+++ b/run_tests.py
@@ -12,7 +12,6 @@ import re
 import unittest
 
 import stem.util.conf
-import stem.util.system
 
 from arm.util import load_settings
 
@@ -27,6 +26,7 @@ ARM_BASE = os.path.dirname(__file__)
 SRC_PATHS = [os.path.join(ARM_BASE, path) for path in (
   'arm',
   'test',
+  'run_tests.py',
 )]
 
 
@@ -46,10 +46,10 @@ def main():
 
   static_check_issues = {}
 
-  if stem.util.system.is_available("pyflakes"):
+  if is_pyflakes_available():
     static_check_issues.update(get_pyflakes_issues(SRC_PATHS))
 
-  if stem.util.system.is_available("pep8"):
+  if is_pep8_available():
     static_check_issues.update(get_stylistic_issues(SRC_PATHS))
 
   if static_check_issues:
diff --git a/test/settings.cfg b/test/settings.cfg
index 169a016..e3b3b75 100644
--- a/test/settings.cfg
+++ b/test/settings.cfg
@@ -50,4 +50,6 @@ pep8.blacklist ./arm/torrcPanel.py
 
 pyflakes.ignore arm/prereq.py => 'stem' imported but unused
 pyflakes.ignore arm/prereq.py => 'curses' imported but unused
+pyflakes.ignore run_tests.py => 'pyflakes' imported but unused
+pyflakes.ignore run_tests.py => 'pep8' imported but unused
 





More information about the tor-commits mailing list