[tor-commits] [tor/master] Remove the assigned-but-unused chosen_named_idx local variable

nickm at torproject.org nickm at torproject.org
Tue Aug 26 13:44:29 UTC 2014


commit 051dd9c409d9d7e841a3d818036f733f08a38d88
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Aug 25 11:26:08 2014 -0400

    Remove the assigned-but-unused chosen_named_idx local variable
    
    It had been used in consensus method 1.  But now that 13 is the
    minimum (see #10163), we don't need it around.
    
    Found by sysrqb.
---
 src/or/dirvote.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 67d14f9..0cdf886 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -1269,7 +1269,6 @@ networkstatus_compute_consensus(smartlist_t *votes,
                      * is the same flag as votes[j]->known_flags[b]. */
     int *named_flag; /* Index of the flag "Named" for votes[j] */
     int *unnamed_flag; /* Index of the flag "Unnamed" for votes[j] */
-    int chosen_named_idx;
     int n_authorities_measuring_bandwidth;
 
     strmap_t *name_to_id_map = strmap_new();
@@ -1287,7 +1286,6 @@ networkstatus_compute_consensus(smartlist_t *votes,
     unnamed_flag = tor_calloc(sizeof(int), smartlist_len(votes));
     for (i = 0; i < smartlist_len(votes); ++i)
       unnamed_flag[i] = named_flag[i] = -1;
-    chosen_named_idx = smartlist_string_pos(flags, "Named");
 
     /* Build the flag indexes. Note that no vote can have more than 64 members
      * for known_flags, so no value will be greater than 63, so it's safe to





More information about the tor-commits mailing list