[tor-commits] [tor/master] Suppress coverity warning about overflowing in tor_memeq.

nickm at torproject.org nickm at torproject.org
Thu Aug 21 16:14:09 UTC 2014


commit c43e45d0eaac67caa5b6c1449fb1e4931a410933
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Aug 21 10:44:13 2014 -0400

    Suppress coverity warning about overflowing in tor_memeq.
    
    The unsigned underflow here is defined and intentional.
    
    CID 202482
---
 src/common/di_ops.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/common/di_ops.c b/src/common/di_ops.c
index 14a1443..f03b2b7 100644
--- a/src/common/di_ops.c
+++ b/src/common/di_ops.c
@@ -130,6 +130,7 @@ tor_memeq(const void *a, const void *b, size_t sz)
    *            1 & ((any_difference - 1) >> 8) == 0
    */
 
+  /*coverity[overflow]*/
   return 1 & ((any_difference - 1) >> 8);
 }
 





More information about the tor-commits mailing list