[tor-commits] [meek/master] Actually use the callback arg.

dcf at torproject.org dcf at torproject.org
Sat Apr 26 05:03:03 UTC 2014


commit f0083e5e5b9b4d05bb9da8f7180b53c7758aaba2
Author: David Fifield <david at bamsoftware.com>
Date:   Fri Apr 25 21:13:27 2014 -0700

    Actually use the callback arg.
    
    Previously it was hardcoded to the same value that happened to be passed
    as an argument, so it worked the same but was confusing. Found by gk in
    https://trac.torproject.org/projects/tor/ticket/11183#comment:20.
---
 firefox/components/main.js |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/firefox/components/main.js b/firefox/components/main.js
index d1283e7..d8b40f4 100644
--- a/firefox/components/main.js
+++ b/firefox/components/main.js
@@ -129,7 +129,7 @@ MeekHTTPHelper.LocalConnectionHandler = function(transport) {
 };
 MeekHTTPHelper.LocalConnectionHandler.prototype = {
     readRequest: function(callback) {
-        this.requestreader = new MeekHTTPHelper.RequestReader(this.transport, this.makeRequest.bind(this));
+        this.requestreader = new MeekHTTPHelper.RequestReader(this.transport, callback);
     },
 
     makeRequest: function(req) {





More information about the tor-commits mailing list