[tor-commits] [tor/master] scan-build: in cpuworker, initialize tv_start

nickm at torproject.org nickm at torproject.org
Fri Apr 25 05:30:23 UTC 2014


commit 78bc814c049fe67d0b521a288d3516248e110301
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Apr 18 21:12:45 2014 -0400

    scan-build: in cpuworker, initialize tv_start
    
    scan-build doesn't realize that a request can't be timed at the end
    unless it's timed at the start, and so it's not possible for us to
    be subtracting start from end without start being set.
    Nevertheless, let's not confuse it.
---
 src/or/cpuworker.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/or/cpuworker.c b/src/or/cpuworker.c
index 209274d..6b6a68a 100644
--- a/src/or/cpuworker.c
+++ b/src/or/cpuworker.c
@@ -436,7 +436,7 @@ cpuworker_main(void *data)
     if (req.task == CPUWORKER_TASK_ONION) {
       const create_cell_t *cc = &req.create_cell;
       created_cell_t *cell_out = &rpl.created_cell;
-      struct timeval tv_start, tv_end;
+      struct timeval tv_start = {0,0}, tv_end;
       int n;
       rpl.timed = req.timed;
       rpl.started_at = req.started_at;





More information about the tor-commits mailing list