[tor-commits] [tor/master] Warn when the Extended ORPort should be on but it's not.

[nickm at torproject.org]

commit 43b9b5138999f0b8619cc7f90c1b09c1b9aac42c
Author: George Kadianakis <desnacked at riseup.net>
Date:   Tue Sep 24 12:30:25 2013 +0100

    Warn when the Extended ORPort should be on but it's not.
---
 src/or/config.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/or/config.c b/src/or/config.c
index 37b42e8..8f5e544 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -3176,6 +3176,17 @@ options_validate(or_options_t *old_options, or_options_t *options,
     smartlist_free(options_sl);
   }
 
+  /* If we are a bridge with a pluggable transport proxy but no
+     Extended ORPort, inform the user that she is missing out. */
+  if (server_mode(options) && options->ServerTransportPlugin &&
+      !options->ExtORPort_lines) {
+    log_notice(LD_CONFIG, "We are a bridge with a pluggable transport "
+               "proxy but the Extended ORPort is disabled. The "
+               "Extended ORPort helps Tor communicate with the pluggable "
+               "transport proxy. Please enable it using the ExtORPort "
+               "torrc option.");
+  }
+
   if (options->ConstrainedSockets) {
     /* If the user wants to constrain socket buffer use, make sure the desired
      * limit is between MIN|MAX_TCPSOCK_BUFFER in k increments. */