[tor-commits] [stem/master] Revert "Chaching version comparison and hash function"

atagar at torproject.org atagar at torproject.org
Thu Oct 10 15:51:58 UTC 2013


commit 94b4924a3970fe3877b276ad2d07ccd149ed8d3a
Author: Damian Johnson <atagar at torproject.org>
Date:   Thu Oct 10 08:51:59 2013 -0700

    Revert "Chaching version comparison and hash function"
    
    Wow, shame on me for not even running unit tests. This causes version
    comparisons to infinitely recurse - hot.
---
 stem/version.py |    2 --
 1 file changed, 2 deletions(-)

diff --git a/stem/version.py b/stem/version.py
index 613c4a5..68faa36 100644
--- a/stem/version.py
+++ b/stem/version.py
@@ -187,7 +187,6 @@ class Version(object):
 
     return self.version_str
 
-  @lru_cache()
   def _compare(self, other, method):
     """
     Compares version ordering according to the spec.
@@ -248,7 +247,6 @@ class Version(object):
 
     return self._compare(other, lambda s, o: s >= o)
 
-  @lru_cache()
   def __hash__(self):
     my_hash = 0
 



More information about the tor-commits mailing list