[tor-commits] [tor/master] Add checks to prevent memcmp(., ., negative) in tests (CID 1064417)

nickm at torproject.org nickm at torproject.org
Fri Nov 22 17:33:28 UTC 2013


commit a7410c9199e58bd6c5ff131a994f8e02ccb42b91
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Nov 22 12:33:25 2013 -0500

    Add checks to prevent memcmp(.,.,negative) in tests (CID 1064417)
---
 src/test/test_crypto.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/test/test_crypto.c b/src/test/test_crypto.c
index 6c4820f..22adc6c 100644
--- a/src/test/test_crypto.c
+++ b/src/test/test_crypto.c
@@ -731,11 +731,13 @@ test_crypto_aes_iv(void *arg)
   /* Decrypt with the wrong key. */
   decrypted_size = crypto_cipher_decrypt_with_iv(key2, decrypted2, 4095,
                                              encrypted1, encrypted_size);
+  test_eq(decrypted_size, 4095);
   test_memneq(plain, decrypted2, decrypted_size);
   /* Alter the initialization vector. */
   encrypted1[0] += 42;
   decrypted_size = crypto_cipher_decrypt_with_iv(key1, decrypted1, 4095,
                                              encrypted1, encrypted_size);
+  test_eq(decrypted_size, 4095);
   test_memneq(plain, decrypted2, 4095);
   /* Special length case: 1. */
   encrypted_size = crypto_cipher_encrypt_with_iv(key1, encrypted1, 16 + 1,



More information about the tor-commits mailing list