[tor-commits] [stem/master] Disabling test_event_handling

atagar at torproject.org atagar at torproject.org
Sun May 12 02:51:20 UTC 2013


commit 2f69e4de1e5d9982dfe94a90c62da3c71edf96a2
Author: Damian Johnson <atagar at torproject.org>
Date:   Sat May 11 17:21:13 2013 -0700

    Disabling test_event_handling
    
    Well damn. Even with expanded sleeps test_event_handling is occasionally
    failing on the jenkins host. No test is better than a flaky test so disabling
    this for the time being.
    
    Ticket for fixing this test...
    
    https://trac.torproject.org/8865
---
 test/integ/control/controller.py |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/test/integ/control/controller.py b/test/integ/control/controller.py
index 4909399..f0b94a9 100644
--- a/test/integ/control/controller.py
+++ b/test/integ/control/controller.py
@@ -108,6 +108,14 @@ class TestController(unittest.TestCase):
     them. Then remove the listeners.
     """
 
+    # TODO: This test relies on the timing of BW events which has proved to
+    # be unreliable on our jenkins host (probably related to system load).
+    # This occures even with sizable sleeps so this test needs to be disabled
+    # until we can come up with a test that doesn't rely on event timing.
+
+    test.runner.skip(self, "(presently unreliable)")
+    return
+
     if test.runner.require_control(self):
       return
 





More information about the tor-commits mailing list