[tor-commits] [stem/master] Clarifying requirements for timing out launch_tor()

atagar at torproject.org atagar at torproject.org
Fri Mar 8 15:58:59 UTC 2013


commit d45f89dbce487aec2a3988138966387da55adaf5
Author: Damian Johnson <atagar at torproject.org>
Date:   Fri Mar 8 07:57:28 2013 -0800

    Clarifying requirements for timing out launch_tor()
    
    The signal timeout we were doing isn't just *nix specific, but relies on global
    state. It turns out that no languages really have a good method for doing this
    sort of arbitrary timeout - pity...
    
    http://eli.thegreenplace.net/2011/08/22/how-not-to-set-a-timeout-on-a-computation-in-python/
---
 stem/process.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/stem/process.py b/stem/process.py
index 0764d7f..e848140 100644
--- a/stem/process.py
+++ b/stem/process.py
@@ -47,8 +47,8 @@ def launch_tor(tor_cmd = "tor", args = None, torrc_path = None, completion_perce
   default, but if you have a 'Log' entry in your torrc then you'll also need
   'Log NOTICE stdout'.
 
-  Note: The timeout argument does not work on Windows (`ticket
-  <https://trac.torproject.org/5783>`_)
+  Note: The timeout argument does not work on Windows, and relies on the global
+  state of the signal module.
 
   :param str tor_cmd: command for starting tor
   :param list args: additional arguments for tor



More information about the tor-commits mailing list