[tor-commits] [tor/master] Fix signed/unsigned comparison warning

nickm at torproject.org nickm at torproject.org
Fri Jun 14 05:50:24 UTC 2013


commit bd6bd1c9be24dac2350403beebae2dae55c639b6
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Jun 14 01:41:53 2013 -0400

    Fix signed/unsigned comparison warning
---
 src/or/relay.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/or/relay.c b/src/or/relay.c
index f682d6a..2fe6448 100644
--- a/src/or/relay.c
+++ b/src/or/relay.c
@@ -2540,7 +2540,7 @@ append_cell_to_circuit_queue(circuit_t *circ, channel_t *chan,
           (uint32_t)(((double)orcirc->max_middle_cells) *
                      ORCIRC_MAX_MIDDLE_KILL_THRESH);
 
-        if (queue->n + 1 >= hard_max_middle_cells) {
+        if ((unsigned)queue->n + 1 >= hard_max_middle_cells) {
           /* Queueing this cell would put queue over the kill theshold */
           log_warn(LD_CIRC,
                    "Got a cell exceeding the hard cap of %u in the "
@@ -2556,7 +2556,7 @@ append_cell_to_circuit_queue(circuit_t *circ, channel_t *chan,
                         orcirc->p_chan->global_identifier));
           circuit_mark_for_close(circ, END_CIRC_REASON_RESOURCELIMIT);
           return;
-        } else if (queue->n + 1 == orcirc->max_middle_cells) {
+        } else if ((unsigned)queue->n + 1 == orcirc->max_middle_cells) {
           /* Only use ==, not >= for this test so we don't spam the log */
           log_warn(LD_CIRC,
                    "While trying to queue a cell, reached the soft cap of %u "





More information about the tor-commits mailing list