[tor-commits] [ooni-probe/develop] Make a note on the socket option settings for blocking.

[isis at torproject.org]

commit 578c6703106c81171e4af5ad45fca22fe8979d76
Author: Isis Lovecruft <isis at torproject.org>
Date:   Thu Feb 28 17:56:29 2013 +0000

    Make a note on the socket option settings for blocking.
---
 nettests/experimental/tls_handshake.py |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/nettests/experimental/tls_handshake.py b/nettests/experimental/tls_handshake.py
index fbd60d8..3c9a033 100644
--- a/nettests/experimental/tls_handshake.py
+++ b/nettests/experimental/tls_handshake.py
@@ -325,7 +325,10 @@ class TLSHandshakeTest(nettest.NetTestCase):
             @param connection: A :class:`OpenSSL.SSL.Connection` object.
             @param host: A tuple of the host IP and port, i.e. ('1.1.1.1', 443).
             """
+            ## xxx TODO to get this to work with a non-blocking socket, see how
+            ##     twisted.internet.tcp.Client handles socket objects.
             connection.setblocking(1)
+
             ## Set the timeout on the connection:
             ##
             ## We want to set SO_RCVTIMEO and SO_SNDTIMEO, which both are