[tor-commits] [stem/master] Inverted conditional for reporting bugs for password exceptions

atagar at torproject.org atagar at torproject.org
Fri Jul 26 16:18:24 UTC 2013


commit 5eda329ed6a288575f61f26ac2a457299c2f9d04
Author: Damian Johnson <atagar at torproject.org>
Date:   Fri Jul 26 09:17:07 2013 -0700

    Inverted conditional for reporting bugs for password exceptions
    
    Issue caught by str4d while porting stem to I2P.
---
 stem/connection.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stem/connection.py b/stem/connection.py
index b90b33a..c221777 100644
--- a/stem/connection.py
+++ b/stem/connection.py
@@ -193,7 +193,7 @@ def _connect(control_socket, password, chroot_path, controller):
     else:
       return controller(control_socket)
   except MissingPassword:
-    if password is None:
+    if password is not None:
       raise ValueError("BUG: authenticate raised MissingPassword despite getting one")
 
     try:



More information about the tor-commits mailing list