[tor-commits] [tor/master] Add more replaycache.c unit tests, bringing coverage to 100% for that file

[nickm at torproject.org]

commit 459d82719348d860d856b8753e07cb4057f692ed
Author: Andrea Shepard <andrea at torproject.org>
Date:   Tue Jul 16 06:02:22 2013 -0700

    Add more replaycache.c unit tests, bringing coverage to 100% for that file
---
 src/test/test_replay.c |  171 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 171 insertions(+)

diff --git a/src/test/test_replay.c b/src/test/test_replay.c
index de841ad..9230081 100644
--- a/src/test/test_replay.c
+++ b/src/test/test_replay.c
@@ -32,6 +32,40 @@ test_replaycache_alloc(void)
 }
 
 static void
+test_replaycache_badalloc(void)
+{
+  replaycache_t *r = NULL;
+
+  /* Negative horizon should fail */
+  r = replaycache_new(-600, 300);
+  test_assert(r == NULL);
+  /* Negative interval should get adjusted to zero */
+  r = replaycache_new(600, -300);
+  test_assert(r != NULL);
+  test_eq(r->scrub_interval, 0);
+  replaycache_free(r);
+  /* Negative horizon and negative interval should still fail */
+  r = replaycache_new(-600, -300);
+  test_assert(r == NULL);
+
+ done:
+  if (r) replaycache_free(r);
+
+  return;
+}
+
+static void
+test_replaycache_free_null(void)
+{
+  replaycache_free(NULL);
+  /* Assert that we're here without horrible death */
+  test_assert(1);
+
+ done:
+  return;
+}
+
+static void
 test_replaycache_miss(void)
 {
   replaycache_t *r = NULL;
@@ -45,6 +79,12 @@ test_replaycache_miss(void)
         (int)strlen(test_buffer), NULL);
   test_eq(result, 0);
 
+  /* poke the bad-parameter error case too */
+  result =
+    replaycache_add_and_test_internal(1200, NULL, test_buffer,
+        (int)strlen(test_buffer), NULL);
+  test_eq(result, 0);
+
  done:
   if (r) replaycache_free(r);
 
@@ -163,16 +203,147 @@ test_replaycache_noexpire(void)
   return;
 }
 
+static void
+test_replaycache_scrub(void)
+{
+  replaycache_t *r = NULL;
+  int result;
+  char digest[DIGEST_LEN];
+
+  r = replaycache_new(600, 300);
+  test_assert(r != NULL);
+
+  /* Set up like in test_replaycache_hit() */
+  result =
+    replaycache_add_and_test_internal(100, r, test_buffer,
+        (int)strlen(test_buffer), NULL);
+  test_eq(result, 0);
+
+  result =
+    replaycache_add_and_test_internal(200, r, test_buffer,
+        (int)strlen(test_buffer), NULL);
+  test_eq(result, 1);
+
+  /*
+   * Poke a few replaycache_scrub_if_needed_internal() error cases that
+   * can't happen through replaycache_add_and_test_internal()
+   */
+
+  /* Null cache */
+  replaycache_scrub_if_needed_internal(300, NULL);
+  /* Assert we're still here */
+  test_assert(1);
+
+  /* Make sure we hit the aging-out case too */
+  replaycache_scrub_if_needed_internal(1500, r);
+  /* Assert that we aged it */
+  test_eq(digestmap_size(r->digests_seen), 0);
+
+ done:
+  if (r) replaycache_free(r);
+
+  return;
+}
+
+static void
+test_replaycache_future(void)
+{
+  replaycache_t *r = NULL;
+  int result;
+  time_t elapsed = 0;
+
+  r = replaycache_new(600, 300);
+  test_assert(r != NULL);
+
+  /* Set up like in test_replaycache_hit() */
+  result =
+    replaycache_add_and_test_internal(100, r, test_buffer,
+        (int)strlen(test_buffer), &elapsed);
+  test_eq(result, 0);
+  /* elapsed should still be 0, since it wasn't written */
+  test_eq(elapsed, 0);
+
+  result =
+    replaycache_add_and_test_internal(200, r, test_buffer,
+        (int)strlen(test_buffer), &elapsed);
+  test_eq(result, 1);
+  /* elapsed should be the time since the last hit */
+  test_eq(elapsed, 100);
+
+  /*
+   * Now let's turn the clock back to get coverage on the cache entry from the
+   * future not-supposed-to-happen case.
+   */
+  result =
+    replaycache_add_and_test_internal(150, r, test_buffer,
+        (int)strlen(test_buffer), &elapsed);
+  /* We should still get a hit */
+  test_eq(result, 1);
+  /* ...but it shouldn't let us see a negative elapsed time */
+  test_eq(elapsed, 0);
+
+ done:
+  if (r) replaycache_free(r);
+
+  return;
+}
+
+static void
+test_replaycache_realtime(void)
+{
+  replaycache_t *r = NULL;
+  /*
+   * Negative so we fail if replaycache_add_test_and_elapsed() doesn't
+   * write to elapsed.
+   */
+  time_t elapsed = -1;
+  int result;
+
+  /* Test the realtime as well as *_internal() entry points */
+  r = replaycache_new(600, 300);
+  test_assert(r != NULL);
+
+  /* This should miss */
+  result =
+    replaycache_add_and_test(r, test_buffer, (int)strlen(test_buffer));
+  test_eq(result, 0);
+
+  /* This should hit */
+  result =
+    replaycache_add_and_test(r, test_buffer, (int)strlen(test_buffer));
+  test_eq(result, 1);
+
+  /* This should hit and return a small elapsed time */
+  result =
+    replaycache_add_test_and_elapsed(r, test_buffer,
+                                     (int)strlen(test_buffer), &elapsed);
+  test_eq(result, 1);
+  test_assert(elapsed >= 0);
+  test_assert(elapsed <= 5);
+
+  /* Scrub it to exercise that entry point too */
+  replaycache_scrub_if_needed(r);
+
+ done:
+  if (r) replaycache_free(r);
+  return;
+}
+
 #define REPLAYCACHE_LEGACY(name) \
   { #name, legacy_test_helper, 0, &legacy_setup, test_replaycache_ ## name }
 
 struct testcase_t replaycache_tests[] = {
   REPLAYCACHE_LEGACY(alloc),
+  REPLAYCACHE_LEGACY(badalloc),
+  REPLAYCACHE_LEGACY(free_null),
   REPLAYCACHE_LEGACY(miss),
   REPLAYCACHE_LEGACY(hit),
   REPLAYCACHE_LEGACY(age),
   REPLAYCACHE_LEGACY(elapsed),
   REPLAYCACHE_LEGACY(noexpire),
+  REPLAYCACHE_LEGACY(scrub),
+  REPLAYCACHE_LEGACY(future),
+  REPLAYCACHE_LEGACY(realtime),
   END_OF_TESTCASES
 };