[tor-commits] [stem/master] Conforming to E711 (None checks by identity)

atagar at torproject.org atagar at torproject.org
Mon Jan 7 09:07:59 UTC 2013


commit cca1b3c9854fc04ad3c4ff13a22d1ff9c632b5fe
Author: Damian Johnson <atagar at torproject.org>
Date:   Sun Jan 6 19:40:43 2013 -0800

    Conforming to E711 (None checks by identity)
    
    E711 is actually something that we *were* trying to comply with (as are several
    other PEP8 warnings we're getting, actually). Fixing the one occurance.
---
 stem/connection.py       |    2 +-
 test/check_whitespace.py |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/stem/connection.py b/stem/connection.py
index 3ca4462..e4760ef 100644
--- a/stem/connection.py
+++ b/stem/connection.py
@@ -183,7 +183,7 @@ def _connect(control_socket, password, chroot_path, controller):
   try:
     authenticate(control_socket, password, chroot_path)
     
-    if controller == None:
+    if controller is None:
       return control_socket
     else:
       return controller(control_socket)
diff --git a/test/check_whitespace.py b/test/check_whitespace.py
index f9008f5..7b7a181 100644
--- a/test/check_whitespace.py
+++ b/test/check_whitespace.py
@@ -47,7 +47,7 @@ def pep8_issues(base_path = DEFAULT_TARGET):
   # We're gonna trim these down by cateogry but include the pep8 checks to
   # prevent regression.
   
-  ignored_issues = "E111,E121,W293,E501,E302,E701,E251,E261,W391,E127,E241,E128,E226,E231,E202,E201,E203,E124,E211,E222,E225,E221,E126,E262,E271,E502,E303,E711"
+  ignored_issues = "E111,E121,W293,E501,E302,E701,E251,E261,W391,E127,E241,E128,E226,E231,E202,E201,E203,E124,E211,E222,E225,E221,E126,E262,E271,E502,E303"
   
   issues = {}
   pep8_output = system.call("pep8 --ignore %s %s" % (ignored_issues, base_path))





More information about the tor-commits mailing list